Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Experimental) VReplication Workflows: cache workflow metadata in topo and use to filter target shards for vreplication commands #14211

Closed
wants to merge 3 commits into from
Closed

(Experimental) VReplication Workflows: cache workflow metadata in topo and use to filter target shards for vreplication commands #14211

wants to merge 3 commits into from
+1,503 −420

Conversation

rohit-nayak-ps
Copy link
Contributor

Description

  • Add workflow metadata to keyspace topo object
  • Store metadata while creating a MoveTables object (currently only implemented for vtctlclient)
  • Use the cached information, if available, to only contact primaries of participating shards for all workflow commands

Initial commit to check if any tests break due to this change.

Testing has been done by adding extra logging and checking that adding caching causes non-participating shards not to be contacted. Since we don't store stats for such calls, not sure how we can add tests for this without adding specific stats in vtctld.

Related Issue(s)

#14204

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

Deployment Notes

@rohit-nayak-ps
Add workflow metadata to keyspace topo object. Save it currently only…
69527e5 
… for movetables and use the cached information, if available, to only contact primaries of participating shards for all workflow commands

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps rohit-nayak-ps added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: VReplication Do Not Merge labels Oct 8, 2023
@vitess-bot
Copy link
Contributor

vitess-bot bot commented Oct 8, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Oct 8, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Oct 8, 2023
@rohit-nayak-ps rohit-nayak-ps removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Oct 8, 2023
@rohit-nayak-ps
Overwrite workflow if same name exists, since we don't delete from to…
c1f05ba 
…po record when workflow is deleted. Otherwise e2e tests which create same workflow name fail. Fix TestAPI

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@rohit-nayak-ps
Cache workflow for Reshard as well since same workflow name is used i…
c605f38 
…n e2e tests for reshard and movetables

Signed-off-by: Rohit Nayak <rohit@planetscale.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 9, 2023

This PR is being marked as stale because it has been open for 30 days with no activity. To rectify, you may do any of the following:

  • Push additional commits to the associated branch.
  • Remove the stale label.
  • Add a comment indicating why it is not stale.

If no action is taken within 7 days, this PR will be closed.

@github-actions github-actions bot added the Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. label Nov 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepthi deepthi Awaiting requested review from deepthi deepthi will be requested when the pull request is marked ready for review deepthi is a code owner

@harshit-gangal harshit-gangal Awaiting requested review from harshit-gangal harshit-gangal will be requested when the pull request is marked ready for review harshit-gangal is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord will be requested when the pull request is marked ready for review mattlord is a code owner

@ajm188 ajm188 Awaiting requested review from ajm188 ajm188 will be requested when the pull request is marked ready for review ajm188 is a code owner

@notfelineit notfelineit Awaiting requested review from notfelineit notfelineit will be requested when the pull request is marked ready for review notfelineit is a code owner

Assignees
No one assigned
Labels
Component: VReplication Do Not Merge Stale Marks PRs as stale after a period of inactivity, which are then closed after a grace period. Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@rohit-nayak-ps